[WFCORE-3923] Provide a profile to run enforcer rule for downstream p…

[gaol]

…rojects - wildfly-core

Added a profile enforce-product to check redhat dependencies

Jira: https://issues.jboss.org/browse/WFCORE-3923

[wildfly-ci]

Core - Full Integration Build 7530 outcome was UNKNOWN using a merge of 74c2a10
Summary: Canceled (Error while applying patch; cannot find commit 69d6b58 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/3356/merge branch was updated and the commit selected for the ... Build time: 00:00:15

[gaol]

retest this please

[wildfly-ci]

Core - Full Integration Build 7582 outcome was FAILURE using a merge of 74c2a10
Summary: Tests failed: 1 (1 new), passed: 4414, ignored: 141 Build time: 01:34:54

Failed tests

org.jboss.as.test.clustering.cluster.singleton.SingletonPolicyServiceTestCase.testSingletonService: java.lang.AssertionError
	at org.jboss.as.test.clustering.cluster.singleton.SingletonPolicyServiceTestCase.testSingletonService(SingletonPolicyServiceTestCase.java:157)
------- Stdout: -------
 [0m19:21:31,361 INFO  [org.jboss.modules] (main) JBoss Modules version 1.8.5.Final
 [0m [0m19:21:31,619 INFO  [org.jboss.msc] (main) JBoss MSC version 1.4.2.Final
 [0m [0m19:21:31,629 INFO  [org.jboss.threads] (main) JBoss Threads version 2.3.2.Final
 [0m [0m19:21:31,756 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: WildFly Full 14.0.0.Beta1-SNAPSHOT (WildFly Core 6.0.0.Alpha3-SNAPSHOT) starting
 [0m [0m19:21:33,040 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/core-service=management/management-interface=http-interface' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m19:21:33,102 INFO  [org.wildfly.security] (ServerService Thread Pool -- 21) ELY00001: WildFly Elytron version 1.3.3.Final
 [0m [0m19:21:33,129 INFO  [org.jboss.as.controller.management-deprecated] (ServerService Thread Pool -- 34) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m19:21:33,216 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m19:21:33,235 INFO  [org.xnio] (MSC service thread 1-3) XNIO version 3.6.3.Final
 [0m [0m19:21:33,240 INFO  [org.xnio.nio] (MSC service thread 1-3) XNIO NIO Implementation Version 3.6.3.Final
 [0m [0m19:21:33,280 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 41) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 1.4)
 [0m [0m19:21:33,296 INFO  [org.jboss.as.ee] (ServerService Thread Pool -- 44) WFLYEE0119: The system property 'ee8.preview.mode' is NOT set to 'true'. For provided EE 8 APIs where the EE 8 version of the API differs from what is supported in EE 7, the EE 7 variant of the API will be used. Support for this setting will be removed once all EE 8 APIs are provided and certified.
 [0m [0m19:21:33,308 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 48) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [33m19:21:33,316 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 68) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
 [0m [0m19:21:33,327 INFO  [org.jboss.as.webservices] (ServerService Thread Pool -- 70) WFLYWS0002: Activating WebServices Extension
 [0m [0m19:21:33,339 INFO  [org.jboss.as.security] (ServerService Thread Pool -- 65) WFLYSEC0002: Activating Security Subsystem
 [0m [0m19:21:33,367 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 59) WFLYNAM0001: Activating Naming Subsystem
 [0m [0m19:21:33,382 INFO  [org.jboss.as.jsf] (ServerService Thread Pool -- 56) WFLYJSF0007: Activated the following JSF Implementations: [main]
 [0m [0m19:21:33,389 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 53) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 4.0.12
 [0m [0m19:21:33,401 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 50) WFLYRS0016: RESTEasy version 3.5.1.Final
 [0m [0m19:21:33,418 INFO  [org.jboss.remoting] (MSC service thread 1-6) JBoss Remoting version 5.0.7.Final
 [0m [0m19:21:33,436 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-6) WFLYUT0003: Undertow 2.0.9.Final starting
 [0m [0m19:21:33,452 INFO  [org.jboss.as.security] (MSC service thread 1-1) WFLYSEC0001: Current PicketBox version=5.0.3.Final
 [0m [0m19:21:33,453 INFO  [org.jboss.as.naming] (MSC service thread 1-2) WFLYNAM0003: Starting Naming Service
 [0m [0m19:21:33,454 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 49) WFLYIO001: Worker 'default' has auto-configured to 8 core threads with 64 task threads based on your 4 available processors
 [0m [0m19:21:33,466 INFO  [org.jboss.as.mail.extension] (MSC service thread 1-1) WFLYMAIL0001: Bound mail session [java:jboss/mail/Default]
 [0m [0m19:21:33,489 INFO  [org.jboss.as.connector] (MSC service thread 1-8) WFLYJCA0009: Starting JCA Subsystem (WildFly/IronJacamar 1.4.9.Final)
 [0m [0m19:21:33,489 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-8) WFLYJCA0018: Started Driver service with driver-name = h2
 [0m [0m19:21:33,692 INFO  [org.jboss.as.ejb3] (MSC service thread 1-5) WFLYEJB0482: Strict pool mdb-strict-max-pool is using a max instance size of 16 (per class), which is derived from the number of CPUs on this host.
 [0m [0m19:21:33,694 INFO  [org.jboss.as.ejb3] (MSC service thread 1-7) WFLYEJB0481: Strict pool slsb-strict-max-pool is using a max instance size of 64 (per class), which is derived from thread worker pool sizing.
 [0m [0m19:21:33,716 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 69) WFLYUT0014: Creating file handler for path '/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/clustering/target/wildfly-1/welcome-content' with options [directory-listing: 'false', follow-symlink: 'false', case-sensitive: 'true', safe-symlink-paths: '[]']
 [0m [0m19:21:33,760 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-2) WFLYUT0012: Started server default-server.
 [0m [0m19:21:33,773 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-7) WFLYUT0018: Host default-host starting
 [0m [0m19:21:33,817 INFO  [org.jboss.as.ejb3] (MSC service thread 1-4) WFLYEJB0493: EJB subsystem suspension complete
 [0m [0m19:21:33,856 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0006: Undertow AJP listener ajp listening on [::1]:8009
 [0m [0m19:21:33,860 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-8) WFLYUT0006: Undertow HTTP listener default listening on [::1]:8080
 [0m [0m19:21:33,874 INFO  [org.jboss.modcluster] (ServerService Thread Pool -- 72) MODCLUSTER000001: Initializing mod_cluster version 1.3.9.Final
 [0m [0m19:21:33,887 INFO  [org.jboss.modcluster] (ServerService Thread Pool -- 72) MODCLUSTER000032: Listening to proxy advertisements on /224.0.1.105:23364
 [0m [0m19:21:33,914 INFO  [org.jboss.as.patching] (MSC service thread 1-4) WFLYPAT0050: WildFly Full cumulative patch ID is: base, one-off patches include: none
 [0m [0m19:21:33,938 INFO  [org.jboss.as.connector.subsystems.datasources] (MSC service thread 1-7) WFLYJCA0001: Bound data source [java:jboss/datasources/ExampleDS]
 [0m [33m19:21:33,944 WARN  [org.jboss.as.domain.management.security] (MSC service thread 1-6) WFLYDM0111: Keystore /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/clustering/target/wildfly-1/standalone/configuration/application.keystore not found, it will be auto generated on first use with a self signed certificate for host localhost
 [0m [0m19:21:33,957 INFO  [org.jboss.as.server.deployment.scanner] (MSC service thread 1-7) WFLYDS0013: Started FileSystemDeploymentService for directory /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/clustering/target/wildfly-1/standalone/deployments
 [0m [0m19:21:34,069 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-8) WFLYUT0006: Undertow HTTPS listener https listening on [::1]:8443
 [0m [0m19:21:34,136 INFO  [org.jboss.ws.common.management] (MSC service thread 1-1) JBWS022052: Starting JBossWS 5.2.1.Final (Apache CXF 3.2.4.jbossorg-1) 
 [0m [0m19:21:34,228 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0212: Resuming server
 [0m [0m19:21:34,229 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://[::1]:9990/management
 [0m [0m19:21:34,229 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0051: Admin console listening on http://[::1]:9990
 [0m [0m19:21:34,229 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 14.0.0.Beta1-SNAPSHOT (WildFly Core 6.0.0.Alpha3-SNAPSHOT) started in 3196ms - Started 314 of 601 services (392 services are lazy, passive or on-demand)

[gaol]

@jmesnil Could you please re-run the failed CI jobs and to see if it is OK to merge?
BTW, the similar PR for WildFly wildfly/wildfly#11342 has been merged.

[jmesnil]

retest this please

[jmesnil]

@gaol Could the enforce-product profile be declared in the root pom.xml instead of duplicating it in the core-feature-pack and core-galleon-pack modules?

[gaol]

@jmesnil it is intended to be only included in core-feature-pack and core-galleon-pack, so that we can only run enforcer rule for these 2 distributed packs in EAP CP streams.

In downstream, all artifacts in these 2 distributed packs are required built from prod team(*-redhat-X). But we still have other community version dependencies, like some test scope dependencies, build tools related dependencies etc. so that we cannot have the profile in the root pom.xml which will enforce all modules.

[jmesnil]

@gaol thanks of the explanation, looks good to me