Fix Pending Request causing timeout #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere never intercepted by requestPaused() and not being async loaded (only intercepted by requestWillBeSent, so may never have been sent) reduces page waiting for spurrious requests
tw4l
approved these changes
Jul 8, 2024
| const { redirectResponse, requestId, request, type } = params; | ||
|
|
||
| const { headers, method, url } = request; | ||
|
|
||
| logNetwork("Network.requestWillBeSent", { | ||
| requestId, | ||
| url, |
ikreymer
added a commit
that referenced
this pull request
Jul 9, 2024
Don't wait for requests that have been not intercepted (`intercepting` is not set) and are not loaded asynchronously (`asyncLoading` is not set) in awaitPageResources() when page is done. Occasionally, it seems some pending requests that only get added via `Network.requestWillBeSent` but never receive a finished/failed message may persist in the pending request list, and will now be discarded. (Large requests that have a streaming response body will have either `intercepting` or `asyncLoading` set and will not be affected)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, it seems some pending requests that only go through
Network.requestWillBeSentbut never receive a finished/failed/blocked message persist in the pending request list.Instead of waiting for them to finish until timeout, just drop these requests. Requests that have never been intercepted (
fetchis set) and are not being loaded asynchronously (asyncLoadingis set) should be discarded when the page is done. Large requests that are streaming the response body, etc.. will have one of these flags set.(Chrome devtools also handles these by marking their state to 'unknown')..
Test:
Removing pending request that was never fetchedis logged.