ClassHierarchy toJson Function #1392
Conversation
…t for AnalysisScope
|
@aakgna please fix the CI builds and then I can look again |
| Iterator<Node> children = root.getChildren(); | ||
| Set<String> subclassNames = new HashSet<>(); | ||
| while (children.hasNext()) { | ||
| Node temp = children.next(); | ||
| subclassNames.add(nodeToString(temp)); | ||
| helperToJson(temp, classNameToSubclassNames); | ||
| } | ||
| // Removes unnecesarry parts from name of the class | ||
| String key = nodeToString(root); | ||
| // inserting the root class to its subclasses into the main hashmap | ||
| classNameToSubclassNames.put(key, subclassNames); |
There was a problem hiding this comment.
Why do we need this code? Can't you just call helperToJSON(root, classNameToSubclassNames) and that will do what you want?
| Object unused = cha.toJson(); | ||
| // assertEquals("", json); |
There was a problem hiding this comment.
Don't we need to write some actual assertions about what we expect to be in the final JSON string?
| Set<String> subclassNames = new HashSet<>(); | ||
|
|
||
| // Process all children of the current node | ||
| if (n.children.size() > 0) { |
There was a problem hiding this comment.
By printing out the JSON in the test and looking it over, I realized that it only handles subclassing, but not interface implementations. E.g., for the interface java.util.Map we see "java.util.Map":[] in the output, missing all the classes that implement that interface. We should update this logic so that for interfaces, we treat all implementing classes and sub-interfaces as subtypes in the outputted JSON. In other words, the JSON should map each class or interface to all of its immediate subtypes, i.e., direct subclasses, direct sub-interfaces, or classes directly implementing an interface.
Creates a JSON variable containing a map from the Root Class to its Subclasses.