Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($theme-default): close dropdown on mouseout (fix #2227) #2303

Merged
merged 1 commit into from
Apr 15, 2020
Merged

fix($theme-default): close dropdown on mouseout (fix #2227) #2303

merged 1 commit into from
Apr 15, 2020

Conversation

Mister-Hope
Copy link
Contributor

@Mister-Hope Mister-Hope commented Apr 14, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meteorlxy meteorlxy changed the title fix($theme-default): dropdown should be close when foucsout (fix #2227) fix($theme-default): close dropdown on mouseout (fix #2227) Apr 15, 2020
@meteorlxy meteorlxy merged commit 430b917 into vuejs:master Apr 15, 2020
@acgotaku
Copy link

acgotaku commented Apr 16, 2020

The PR cause you can not open Languages dropdown in mobile mode. Please check at https://vuepress.vuejs.org/ .Thank you!

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Apr 16, 2020

The PR cause you can not open Languages dropdown in mobile mode. Please check at https://vuepress.vuejs.org/ .Thank you!

Reproduced on my dad's iPhone, sorry for that because I don't have an iPhone iPad or Mac, so I did not test it on safari. It seems that safari has it's different way to deal with pointer-events, not the same as recommanded. I will try to fix it at once.

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Apr 16, 2020

I searched some forum and docs, and since safari has it's own behavior, it will be unpossible to solve this problem with css.

I will fix it by adding some listeners and functions to solve this problem.

@billyyyyy3320
Copy link
Collaborator

billyyyyy3320 commented Apr 16, 2020

@acgotaku Oops, Nice Catch.

@acgotaku
Copy link

@newsbielt703 @Mister-Hope Thanks for your reply!

@Mister-Hope
Copy link
Contributor Author

I fix this issue on PR #2339 , you can try it out. @acgotaku @newsbielt703 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants