Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUPPETSERVER_HOSTNAME is not unset #71

Closed
khenriks opened this issue Mar 4, 2024 · 4 comments · Fixed by #72
Closed

PUPPETSERVER_HOSTNAME is not unset #71

khenriks opened this issue Mar 4, 2024 · 4 comments · Fixed by #72

Comments

@khenriks
Copy link

khenriks commented Mar 4, 2024

According to the documentation, PUPPETSERVER_HOSTNAME is supposed to be unset, but in fact the container explicitly sets it to puppet. This appears to be due to https://github.com/voxpupuli/container-puppetserver/blob/main/puppetserver/Dockerfile#L26. This also breaks compatibility with the old Puppet Labs-maintained images. I had to explicitly unset it myself in my docker compose file.

@rwaffen
Copy link
Sponsor Member

rwaffen commented Mar 4, 2024

thx for the hint. which puppetlabs maintained containers do you mean? as far as i know we have this containers here, because they dont't maintain theirs anymore. (to be more precise they handed this repo over to us, so we could care about)

@khenriks
Copy link
Author

khenriks commented Mar 8, 2024

I'm referring to the original images, as in https://hub.docker.com/r/puppet/puppetserver. My point is that if you're migrating from the old images to these ones, it doesn't work properly, because of the aforementioned issue with PUPPETSERVER_HOSTNAME.

@rwaffen
Copy link
Sponsor Member

rwaffen commented Mar 8, 2024

oh, okay, now i see. will check the code for it and make a fix

@khenriks
Copy link
Author

khenriks commented Mar 9, 2024

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants