-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PUPPETSERVER_HOSTNAME is not unset #71
Comments
thx for the hint. which puppetlabs maintained containers do you mean? as far as i know we have this containers here, because they dont't maintain theirs anymore. (to be more precise they handed this repo over to us, so we could care about) |
I'm referring to the original images, as in https://hub.docker.com/r/puppet/puppetserver. My point is that if you're migrating from the old images to these ones, it doesn't work properly, because of the aforementioned issue with |
oh, okay, now i see. will check the code for it and make a fix |
Thanks for the quick fix! |
According to the documentation,
PUPPETSERVER_HOSTNAME
is supposed to be unset, but in fact the container explicitly sets it topuppet
. This appears to be due to https://github.com/voxpupuli/container-puppetserver/blob/main/puppetserver/Dockerfile#L26. This also breaks compatibility with the old Puppet Labs-maintained images. I had to explicitly unset it myself in my docker compose file.The text was updated successfully, but these errors were encountered: