Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): reference error #9558

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix(docs): reference error #9558

merged 2 commits into from
Aug 9, 2022

Conversation

caoxiemeihao
Copy link
Contributor

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@@ -224,11 +224,11 @@ If the hashed assets and public files aren't deployed together, options for each

```js
experimental: {
renderBuiltUrl(filename: string, { hostType: 'js' | 'css' | 'html', type: 'public' | 'asset' }) {
renderBuiltUrl(filename: string, { hostId: string, hostType: 'js' | 'css' | 'html', type: 'public' | 'asset' }) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, you made me remember we have a bug here, this isn't proper typescript. Would you mind correcting that too?

Suggested change
renderBuiltUrl(filename: string, { hostId: string, hostType: 'js' | 'css' | 'html', type: 'public' | 'asset' }) {
renderBuiltUrl(filename: string, { hostId, hostType, type }: { hostId: string, hostType: 'js' | 'css' | 'html', type: 'public' | 'asset' })) {

And it should also be ```ts instead of js

@patak-dev patak-dev merged commit 6ad6734 into vitejs:main Aug 9, 2022
@caoxiemeihao caoxiemeihao deleted the patch-3 branch August 9, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants