Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): add option passed to chokidar #841

Merged
merged 4 commits into from
Nov 27, 2020
Merged

fix(dev): add option passed to chokidar #841

merged 4 commits into from
Nov 27, 2020

Conversation

underfin
Copy link
Member

antfu
antfu approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I am not sure if it's a good way to keep exposing options form our dependencies in the long term 😂.

This was referenced Oct 2, 2020
Closed
Closed
@underfin underfin linked an issue Nov 27, 2020 that may be closed by this pull request
Hot Module Reload not working Windows Docker + wsl #1153
Closed
@underfin underfin merged commit a73c29b into vitejs:master Nov 27, 2020
@underfin underfin deleted the watchOptions branch November 27, 2020 03:20
@magoerlich
Copy link

LGTM. Although I am not sure if it's a good way to keep exposing options form our dependencies in the long term 😂.

also enabling polling is nothing more than a workaround for issues like #1135
an ignorant one as well, considering not everyone has spare cpu time.
so hmr for people with low-end cpus or mid-tier cpus, but high usage will be broken/unusable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@underfin @magoerlich @antfu