Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note api run in same process #8230

Merged
merged 4 commits into from
May 19, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 19, 2022

Description

Close #8204

Clarify when using createServer and build simultaneously on the same nodejs process

Additional context

Not sure of the perfect spot to put the note.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the documentation Improvements or additions to documentation label May 19, 2022
@bluwy
Copy link
Member Author

bluwy commented May 19, 2022

I also noticed that using process.env.NODE_ENV in the docs breaks dev mode, but prod is not affected. Related issue: vuejs/vitepress#419

patak-dev
patak-dev previously approved these changes May 19, 2022
bluwy and others added 2 commits May 19, 2022 15:53
Co-authored-by: patak <matias.capeletto@gmail.com>
@patak-dev patak-dev merged commit e37a51d into vitejs:main May 19, 2022
@bluwy bluwy deleted the docs-note-api-process branch May 19, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using JavaScript API of "build" and "createServer" at the same time will cause HMR error.
2 participants