Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change workflow sentences #4235

Merged
merged 3 commits into from
Jul 13, 2021
Merged

chore: change workflow sentences #4235

merged 3 commits into from
Jul 13, 2021

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jul 13, 2021 •
edited
Loading

Description

Some changes for workflow created sentences

Additional context

Please feel free to review this PR and propose changes to these sentences

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Jul 13, 2021
@Shinigami92 Shinigami92 self-assigned this Jul 13, 2021
@Shinigami92 @patak-dev
chore: improve sentence
dc9d0b1 
Co-authored-by: patak <matias.capeletto@gmail.com>
nihalgonsalves
nihalgonsalves reviewed Jul 13, 2021
View reviewed changes
Copy link
Member

@nihalgonsalves nihalgonsalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few grammatical suggestions

.github/workflows/issue-labeled.yml Outdated Show resolved Hide resolved
.github/workflows/lock-closed-issues.yml Outdated Show resolved Hide resolved
.github/workflows/lock-closed-issues.yml Outdated Show resolved Hide resolved
.github/workflows/issue-labeled.yml Outdated Show resolved Hide resolved
@Shinigami92 @nihalgonsalves
chore: improve sentences
b0cc2c4 
Co-authored-by: Nihal Gonsalves <nihal@nihalgonsalves.com>
@Shinigami92 Shinigami92 marked this pull request as ready for review July 13, 2021 20:45
@patak-dev patak-dev merged commit 73344a9 into main Jul 13, 2021
@patak-dev patak-dev deleted the change-workflow-sentences branch July 13, 2021 21:56
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@Shinigami92 @patak-dev
@nihalgonsalves @aleclarson
chore: change workflow sentences (vitejs#4235)
5d692a0 
* chore: change workflow sentences

* chore: improve sentence

Co-authored-by: patak <matias.capeletto@gmail.com>

* chore: improve sentences

Co-authored-by: Nihal Gonsalves <nihal@nihalgonsalves.com>

Co-authored-by: patak <matias.capeletto@gmail.com>
Co-authored-by: Nihal Gonsalves <nihal@nihalgonsalves.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihalgonsalves nihalgonsalves nihalgonsalves left review comments

@patak-dev patak-dev patak-dev approved these changes

@GrygrFlzr GrygrFlzr Awaiting requested review from GrygrFlzr

@haoqunjiang haoqunjiang Awaiting requested review from haoqunjiang

@wheatjs wheatjs Awaiting requested review from wheatjs

@antfu antfu Awaiting requested review from antfu

Assignees

@Shinigami92 Shinigami92

Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @patak-dev @nihalgonsalves