test: css modules @import hmr
#314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
commented
May 30, 2020
| test('SFC <style module> w/ @import', async () => { | ||
| const el = await page.$('#sfc-style-css-module-at-import') | ||
| expect(await getComputedColor(el)).toBe('rgb(255, 0, 0)') | ||
| if (!isBuild) { |
There was a problem hiding this comment.
This build will get error.I check it and it is maybe caused by rollup-plugin-vue.
| content.replace('green', 'rgb(0, 0, 0)') | ||
| ) | ||
| await expectByPolling(() => getComputedColor(el), 'rgb(0, 0, 0)') | ||
| } |
There was a problem hiding this comment.
This dev will get error.I don't know why.It will work within browser on dev.
underfin
commented
May 30, 2020
| @@ -79,7 +79,6 @@ export const cssPlugin: ServerPlugin = ({ root, app, watcher, resolver }) => { | |||
| // it cannot be handled as normal css because the js exports may change | |||
| if (filePath.endsWith('.module.css')) { | |||
| moduleCssUpdate(filePath) | |||
| return | |||
| } | |||
There was a problem hiding this comment.
This is a fix. When A improt B.B import C and C has changed. let it can bubbling with C -> B -> A.
yyx990803
force-pushed
the
test-css-module-hmr-@import
branch
from
2402baf
to
5dc90e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.