Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch the dependencies of config file #3031

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

egoist
Copy link
Contributor

@egoist egoist commented Apr 17, 2021

Description

Previously imported files in config file are not watched, cause the config file is bundled, this PR gets a list of imported files from esbuild metadata and restart the dev server when they're changed.

Fixed #2832

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@aleclarson aleclarson added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 17, 2021
@antfu antfu merged commit bb419cb into vitejs:main Apr 17, 2021
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imported file in vite config can't trigger dev server auto restart
4 participants