-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added Multi-Page App example using 'root' #2939
Conversation
When using the root option, it may not be clear to beginners that the root directory needs to be included within the resolve() function. Otherwise, the HTML files will not be found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to improve the docs. In this particular case I don't know if we should add a full example, as it may distract the reader from the main content. Maybe we could just add a single line saying something like
If you specify a different
root
, remember that__dirname
will still be the folder of yourvite.config.js
file when resolving the input paths
Removed examples, changed text.
@patak-js Thanks. I agree, we can remove the extra example. I have made that change, but added an extra sentence that gives a hint as to what a developer needs to change. |
Description
Documentation change in the 'Building For Production' page, 'Multi-Page App' section:
When using the
root
option, it may not be clear to beginners that the root directory needs to be included within theresolve()
function. Otherwise, running the build process will error out due to the HTML files not being found.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).