feat: parameter settings when packaging the library #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
patak-dev
added
enhancement
patak-dev
reviewed
Mar 30, 2021
Shinigami92
suggested changes
Mar 31, 2021
Shinigami92
previously approved these changes
Mar 31, 2021
antfu
previously approved these changes
Apr 4, 2021
yyx990803
reviewed
Apr 9, 2021
yyx990803
previously approved these changes
Apr 9, 2021
Co-authored-by: Evan You <yyx990803@gmail.com>
patak-dev
dismissed stale reviews from yyx990803, antfu, and Shinigami92
via
3bb2975
patak-dev
approved these changes
Apr 9, 2021
Shinigami92
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a summary of #2664 and #2745, thank you