Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update netlify configuration #10545

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Oct 20, 2022

Description

netlify already supports pnpm, refer to netlify/build-image#845

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red
Copy link
Member

@patak-dev
It seems it's specified in Netlify UI too. (that one is not used though)

1:02:56 PM: Different build command detected, going to use the one specified in the Netlify configuration file: 'pnpm ci-docs' versus 'npx pnpm i --store=node_modules/.pnpm-store --frozen-lockfile && npm run ci-docs' in the Netlify UI

https://app.netlify.com/sites/vite-docs-main/deploys/6350c85dbf5a600008d5600e

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Oct 20, 2022
@patak-dev
Copy link
Member

@sapphi-red thanks for the heads up, updated it to pnpm ci-docs. We could also leave it empty I think 🤔

@patak-dev patak-dev merged commit 7562014 into vitejs:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants