Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneded link-time dependency on libz and libexpat #247

Merged
merged 1 commit into from
Feb 24, 2019

Conversation

jankatins
Copy link

My debian build complained about them that they are linked in but that this is not needed. No idea why. My grive works fine with these changes.

@Tatsh
Copy link

Tatsh commented Feb 9, 2019

You should delete the lines instead of commenting them out.

@Tatsh
Copy link

Tatsh commented Feb 9, 2019

Also you can remove these lines in libgrive/CMakeLists.txt:

if ( ZLIB_FOUND )
        set( OPT_LIBS   ${OPT_LIBS}     ${ZLIB_LIBRARIES} )
endif ( ZLIB_FOUND )

@jankatins
Copy link
Author

done

@jankatins jankatins force-pushed the remove-unneded-dependencies branch 2 times, most recently from a73e7ea to e814bee Compare February 9, 2019 22:37
@vitalif vitalif merged commit 00d5148 into vitalif:master Feb 24, 2019
@vitalif
Copy link
Owner

vitalif commented Feb 24, 2019

Thanks, merged

@jankatins jankatins deleted the remove-unneded-dependencies branch August 11, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants