This repository has been archived by the owner on Sep 15, 2023. It is now read-only.
Fix Browsersync html task reload issue #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #251 Only reload once at the end of the stream to keep browser from reloading too early
| @@ -37,7 +37,7 @@ var htmlTask = function() { | |||
| .on('error', handleErrors) | |||
| .pipe(gulpif(global.production, htmlmin(config.tasks.html.htmlmin))) | |||
| .pipe(gulp.dest(paths.dest)) | |||
| .pipe(browserSync.stream()) | |||
| .on('end', browserSync.reload) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It sounds like that should work based on the docs, but I haven't noticed any difference when trying that method. It doesn't seem to really matter until you have a lot of files or a longer nunjucks processing time, but once either of those are an issue using .on('end', browserSync.reload) is the only thing I've seen that consistently solves the problem. Discussed it a little bit in #251, and it didn't sound like anyone else had luck with stream: true either.
|
Sounds good. Thanks for figuring that out! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
Only reload once at the end of the stream to keep browser from reloading too early