Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter out unsupported subtitles for dash #962

Merged
merged 10 commits into from
Dec 4, 2020
Merged

fix: filter out unsupported subtitles for dash #962

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bc68ad1
fix: filter out unsupported subtitles for dash
brandonocasey Sep 29, 2020
d8eadfc
rework to use vhs-utils
brandonocasey Sep 30, 2020
05d3793
update mpd-parser
gkatsev Dec 2, 2020
cf7d6dd
Merge branch 'main' into fix/unsupported-subs
gkatsev Dec 2, 2020
65a359d
Merge branch 'main' into fix/unsupported-subs
gkatsev Dec 2, 2020
5909f5b
update pkg-lock
brandonocasey Dec 3, 2020
9827fa6
do not create media groups without any playlists for dash
brandonocasey Dec 3, 2020
9b2bd20
update to vhs-utils 2.3
gkatsev Dec 3, 2020
5946147
swap mp3 to ec-3. This test will fail in Safari but not in other brow…
gkatsev Dec 3, 2020
3a3700b
override browser support for this test
brandonocasey Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do not create media groups without any playlists for dash
  • Loading branch information
@brandonocasey
brandonocasey committed Dec 3, 2020
commit 9827fa604e4bbd89595078cb22f9a548d14e0572
5 changes: 5 additions & 0 deletions src/media-groups.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,11 @@ export const initialize = {
playlistLoader =
new PlaylistLoader(properties.resolvedUri, vhs, requestOptions);
} else if (sourceType === 'dash') {
const playlists = properties.playlists.filter((p) => p.excludeUntil !== Infinity);

if (!playlists.length) {
return;
}
playlistLoader = new DashPlaylistLoader(
properties.playlists[0],
vhs,
Expand Down