test: Fix a tests that could fail via a race condition #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Jun 27, 2019
| @@ -810,7 +810,7 @@ function(assert) { | |||
|
|
|||
| QUnit.test('setDuration blocks audio and video queue entries until it finishes', | |||
| function(assert) { | |||
| const done = assert.async(); | |||
| const done = assert.async(2); | |||
There was a problem hiding this comment.
wait for two done calls, one from the video appendBuffer and one from the audio appendBuffer.
gkatsev
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes this test fails on Firefox, because audio is appended to the audio buffer, before video, even though we call appendBuffer on video first. This causes the test to end without running the video appendBuffer callback and we get one less assertion than we expect.