Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webdriver manager #21

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Use webdriver manager #21

merged 4 commits into from
Aug 27, 2021

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Jun 30, 2020

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2020

CLA assistant check
All committers have signed the CLA.

@alvarezguille
Copy link
Member

TestBench's Getting Started and Behavior-Driven Development docs should be updated. Could we update those right away or create a separate documentation ticket in testbench?

@ZheSun88
Copy link
Contributor Author

ZheSun88 commented Oct 8, 2020

took a quick look about the documentations Getting Started and behavior-Driven Development

if we use it for our official documentation, probably using a 3rd party plugin is not a good idea. So for a better demonstration, i close this PR and keep the old behavior.

@enver-haase
Copy link
Contributor

In my view, we should leave the whole BDD story out of the equation. Great that we can even build such a stack on top of a block of jelly, but for the initial demonstration and "aha" effect we should focus on the TestbenchElement / PageObject story and how to roll your own.

Copy link
Contributor

@enver-haase enver-haase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved

@Artur- Artur- merged commit af2b6ec into master Aug 27, 2021
@Artur- Artur- deleted the use-webdriver-manager branch August 27, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants