Update to Vaadin 14 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use https for Maven repositories (#17)
web-padawan
reviewed
Feb 10, 2020
There was a problem hiding this comment.
Thanks for the PR.
I created a branch https://github.com/vaadin/testbench-demo/tree/10.0 so please update the README.
Here you are. |
alvarezguille
requested changes
Feb 10, 2020
Remove dependency on vaadin-components-testbench as this is no longer needed.
alvarezguille
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
alvarezguille
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough cut.
You probably want to create a branch for Vaadin 10 LTS and change README.md accordingly.
Also both NPM mode and BOWER (compat mode) should probably both be tested and working.
This change is