Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: update docker and enable buildkit by default #360

Merged
merged 4 commits into from
Sep 10, 2024
Merged

change: update docker and enable buildkit by default #360

merged 4 commits into from
Sep 10, 2024

Conversation

tobybellwood
Copy link
Member

This PR:

  • Updates the version of docker used in builds to 27.x
  • Changes the behaviour to have BuildKit support always-on, but disabled with the DOCKER_BUILDKIT=0 variable

@tobybellwood tobybellwood added this to the 2.21.0 milestone Aug 21, 2024
@tobybellwood tobybellwood marked this pull request as ready for review August 21, 2024 01:06
@shreddedbacon shreddedbacon changed the title Update Docker version, and enable buildkit support by default change: update docker and enable buildkit by default Sep 3, 2024
shreddedbacon
shreddedbacon approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense. If for any reason buildkit enabled by default causes issues, we can update generator.go to change the default to false easily.

@tobybellwood tobybellwood merged commit eb38168 into main Sep 10, 2024
2 checks passed
@tobybellwood tobybellwood deleted the docker-buildkit branch September 10, 2024 04:42
@tobybellwood tobybellwood mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobybellwood @shreddedbacon