Replace grype with trivy for cyclonedx generation #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
I'm not super familiar with trivy scanning, but reading the documentation for trivy scanning with cyclonedx, I am satisfied that this PR solves the problem of transferring from syft to trivy.
shreddedbacon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, we're using trivy as the sbom scanner in insights-handler, but generating sboms with
syfton the remote side.This has lead to issues with format incompatibilities across the two tools - specifically, an update to the cyclonedx format wasn't tracked in both tools and lead to a fatal crash in the handler.
This brings the insights generation in line, tooling wise, by replacing grype with trivy for sbom generation.