Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node16 compatible type declaration #868

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: add node16 compatible type declaration #868

merged 1 commit into from
Jan 24, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#18431

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds type support to imports from nitropack in TS Node16 style module resolution.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jan 23, 2023
@danielroe danielroe requested a review from pi0 January 23, 2023 22:37
@danielroe danielroe self-assigned this Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #868 (a1a600a) into main (5830bf3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   67.32%   67.32%           
=======================================
  Files          59       59           
  Lines        5834     5834           
  Branches      633      633           
=======================================
  Hits         3928     3928           
  Misses       1897     1897           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 113d31e into main Jan 24, 2023
@pi0 pi0 deleted the fix/node16-dts branch January 24, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants