Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow optional output property in user rollup config #751

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This allows users to pass a rollupConfig that doesn't include an output property

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #751 (900604c) into main (b098cb1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   72.35%   72.35%           
=======================================
  Files          57       57           
  Lines        5123     5123           
  Branches      553      553           
=======================================
  Hits         3707     3707           
  Misses       1406     1406           
  Partials       10       10           
Impacted Files Coverage Ξ”
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 8186a02 into main Dec 12, 2022
@pi0 pi0 deleted the fix/rollup-config-types branch December 12, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants