Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude undefined from hook types #1769

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: exclude undefined from hook types #1769

merged 1 commit into from
Sep 27, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#23437

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We need to exclude possibly undefined values from the hook function or it will end up typed as never once processed by hookable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working types labels Sep 27, 2023
@danielroe danielroe requested a review from pi0 September 27, 2023 15:25
@danielroe danielroe self-assigned this Sep 27, 2023
@pi0 pi0 merged commit 303fadb into main Sep 27, 2023
5 of 7 checks passed
@pi0 pi0 deleted the fix/hook-types branch September 27, 2023 20:13
@pi0 pi0 mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants