fix: pass relative ignore paths when scanning public assets #1632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
We now support ignoring public assets (#945) but at the moment we do not resolve/relativise paths, so an ignore pattern of
public/test.txt
would not matchtest.txt
when scanning thepublic/
directory. The issue is that it then becomes impossible to specify ignore patterns that only apply in public directories, for example.This is a change in behaviour but I think more intuitive.
π Checklist