Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): add runtime config and environment variables section #1550

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Aug 7, 2023

πŸ”— Linked issue

Extracted from #1547

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Hebilicious Hebilicious changed the title docs/environment variable docs: add environment variable section Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1550 (94eeb86) into main (a949cb9) will not change coverage.
The diff coverage is n/a.

❗ Current head 94eeb86 differs from pull request most recent head 2475bd4. Consider uploading reports for the commit 2475bd4 to get more accurate results

@@           Coverage Diff           @@
##             main    #1550   +/-   ##
=======================================
  Coverage   76.47%   76.47%           
=======================================
  Files          73       73           
  Lines        7591     7591           
  Branches      757      757           
=======================================
  Hits         5805     5805           
  Misses       1785     1785           
  Partials        1        1           

@pi0 pi0 force-pushed the docs/environment-variable branch from 94eeb86 to 2475bd4 Compare August 7, 2023 18:02
@pi0 pi0 changed the title docs: add environment variable section docs(config): add runtime config and environment variables section Aug 7, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for nice and elegant PR ❀️ (i have made few refactors hope are fine to you)

@pi0 pi0 merged commit 19466a0 into main Aug 7, 2023
7 checks passed
@pi0 pi0 deleted the docs/environment-variable branch August 7, 2023 18:04
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants