Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cloudflare-pages-static #1310

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Jun 14, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add a cloudflare-pages static preset

References :

https://github.com/unjs/nitro/pull/1073/files
https://github.com/unjs/nitro/pull/1127/files

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1310 (d0f135b) into main (88b4e11) will decrease coverage by 0.82%.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
- Coverage   77.00%   76.18%   -0.82%     
==========================================
  Files          68       68              
  Lines        6848     6942      +94     
  Branches      686      686              
==========================================
+ Hits         5273     5289      +16     
- Misses       1574     1652      +78     
  Partials        1        1              
Impacted Files Coverage Ξ”
src/presets/cloudflare-pages.ts 58.73% <18.75%> (-41.27%) ⬇️

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ’― Trying locally, wrangler dev shows some warnings about possible header reorder however seems false positive

@pi0 pi0 merged commit 46f4ddf into unjs:main Jun 18, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants