Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(routing): add middleware section #1307

Merged
merged 6 commits into from
Aug 6, 2023

Conversation

Barbapapazes
Copy link
Member

πŸ”— Linked issue

fix #1306

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Usage of middlewares are not documented. This PR is a try to add documentation about middlewares.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Jun 13, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 06b7ddc

@pi0 pi0 changed the title docs: add middlewares docs: add middleware section Jun 13, 2023
@Hebilicious Hebilicious self-assigned this Jun 30, 2023
@Hebilicious Hebilicious added the documentation Improvements or additions to documentation label Jun 30, 2023 — with Volta.net
@Hebilicious Hebilicious self-requested a review June 30, 2023 19:17
@Hebilicious
Copy link
Member

This is looking good, thanks @Barbapapazes !

@Hebilicious Hebilicious requested a review from pi0 July 1, 2023 21:27
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #1307 (5558a13) into main (1d0c120) will not change coverage.
Report is 63 commits behind head on main.
The diff coverage is n/a.

❗ Current head 5558a13 differs from pull request most recent head 06b7ddc. Consider uploading reports for the commit 06b7ddc to get more accurate results

@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   76.64%   76.64%           
=======================================
  Files          71       71           
  Lines        7241     7241           
  Branches      723      723           
=======================================
  Hits         5550     5550           
  Misses       1690     1690           
  Partials        1        1           

@pi0 pi0 changed the title docs: add middleware section docs(routing): add middleware section Aug 6, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For now added it under routing section for similification

@pi0 pi0 merged commit a64133c into unjs:main Aug 6, 2023
5 checks passed
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing middlewares docs
3 participants