Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for failOnError #1294

Merged
merged 3 commits into from
Jun 20, 2023
Merged

feat: add support for failOnError #1294

merged 3 commits into from
Jun 20, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#14676

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds support for automatically failing a build/prerender if prerender.failOnError is enabled.

CleanShot 2023-06-08 at 14 15 58

For custom control, a user could register their own hook on prerender:route.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Jun 8, 2023
@danielroe danielroe requested a review from pi0 June 8, 2023 13:18
@danielroe danielroe self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #1294 (56f3499) into main (3aa642b) will decrease coverage by 0.05%.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   76.59%   76.54%   -0.05%     
==========================================
  Files          70       70              
  Lines        7087     7104      +17     
  Branches      705      707       +2     
==========================================
+ Hits         5428     5438      +10     
- Misses       1657     1665       +8     
+ Partials        2        1       -1     
Impacted Files Coverage Ξ”
src/prerender.ts 86.90% <26.66%> (-2.63%) ⬇️
src/options.ts 94.35% <100.00%> (+0.01%) ⬆️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

@pi0 pi0 merged commit cf70cd4 into main Jun 20, 2023
5 of 6 checks passed
@pi0 pi0 deleted the feat/fail-on-error branch June 20, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants