Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): respect output path from main preset #1114

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#19883

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

At the moment we hard code nitro-prerender preset command to assume a certain directory structure. This respects the 'host' nitro preset output directories to produce the preview command.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 5, 2023
@danielroe danielroe requested a review from pi0 April 5, 2023 12:23
@danielroe danielroe self-assigned this Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #1114 (fab6eba) into main (c2e1e7c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   67.63%   67.66%   +0.03%     
==========================================
  Files          63       63              
  Lines        6364     6370       +6     
  Branches      711      712       +1     
==========================================
+ Hits         4304     4310       +6     
  Misses       2045     2045              
  Partials       15       15              
Impacted Files Coverage Ξ”
src/presets/nitro-prerender.ts 100.00% <ΓΈ> (ΓΈ)
src/prerender.ts 89.28% <100.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix(prerender): respect 'host' output paths fix(prerender): respect output path from main preset Apr 10, 2023
@pi0 pi0 merged commit 2a18785 into main Apr 10, 2023
@pi0 pi0 deleted the fix/prerender-dir branch April 10, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants