Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customising generated tsconfig path #1021

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#13920

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This allows customising the types/tsconfig.json path in case we want it to be in a different location or file name.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Mar 6, 2023
@danielroe danielroe requested a review from pi0 March 6, 2023 15:23
@danielroe danielroe self-assigned this Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #1021 (9391f2c) into main (a5c5a48) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 9391f2c differs from pull request most recent head 9276667. Consider uploading reports for the commit 9276667 to get more accurate results

@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
- Coverage   67.67%   67.60%   -0.07%     
==========================================
  Files          61       61              
  Lines        6171     6174       +3     
  Branches      694      693       -1     
==========================================
- Hits         4176     4174       -2     
- Misses       1985     1989       +4     
- Partials       10       11       +1     
Impacted Files Coverage Ξ”
src/build.ts 44.62% <100.00%> (ΓΈ)
src/options.ts 86.79% <100.00%> (+0.03%) ⬆️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)
src/presets/cloudflare-pages.ts 85.26% <0.00%> (-1.06%) ⬇️
src/rollup/config.ts 87.44% <0.00%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/types/nitro.ts Outdated Show resolved Hide resolved
src/build.ts Outdated Show resolved Hide resolved
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0 pi0 merged commit 6260f9a into main Mar 6, 2023
@pi0 pi0 deleted the feat/customisable-tsconfig-path branch March 6, 2023 16:09
@danielroe danielroe mentioned this pull request Mar 6, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants