Add payment reference, other improvements #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ps1dr3x
commented
Aug 26, 2024
ps1dr3x
commented
- Add paymentReference field in the escrow contract (EscrowInput, Escrow)
- Unicrow.pay() function returns escrow ID
- Arbitrator can call Unicrow.refund(), which will refund also their fee
- UnicrowArbitrator.arbitrate() returns final amounts the same way as UnicrowDispute.approveSettlement()
- Arbitrator can call Unicrow.refund(), which will refund also their fee - UnicrowArbitrator.arbitrate() returns final amounts the same way as UncirowDispute.approveSettlement()
- paymentReference added to EscrowInput and Escrow types and Pay() event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.