Don't clobber EIP after non INT/SYSCALL exception #875
Conversation
…errupt was user-generated
qemu/target-i386/seg_helper.c
Outdated
| @@ -939,6 +939,7 @@ void helper_syscall(CPUX86State *env, int next_eip_addend) | |||
| CPUState *cs = CPU(x86_env_get_cpu(env)); | |||
|
|
|||
| cs->exception_index = EXCP_SYSCALL; | |||
| env->exception_is_int = 1; | |||
There was a problem hiding this comment.
i need to look at the code closer, but this worries me, as "exception_is_int" is also used elsewhere, so you set this here may trigger some unwanted behaviour.
There was a problem hiding this comment.
to be safe (and future-proof), is it better to create a new field in env for this?
rhelmot
force-pushed
the
fix/int_eip_update
branch
from
4b876cb
to
683830a
Compare
|
I looked at this a little more carefully and it seems that function I added that line to was guarded by I pushed the change removing that line, this can be merged now. |
|
merged, thanks! |
… the interrupt was user-generated (unicorn-engine#875)" This reverts commit 363cbac.
Fixes #872