Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Enforce Rollback permissions #2288

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

madsrasmussen
Copy link
Contributor

Description

Fixes: umbraco/Umbraco-CMS#17056

This PR enables the permissions and conditions functionality for the Rollback button.

It is solved by registering it as an entity action. Unfortunately, the rollback modal doesn't work outside the document workspace so I had to only allow the entity action inside the workspace through a condition.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen changed the title Bugfix: Rollback permissions Bugfix: Enforce Rollback permissions Sep 13, 2024
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@warrenbuckley
Copy link
Contributor

WOW that was fast @madsrasmussen

  • Permission shows/hides the button in the UI as expected ✅

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

@nielslyngsoe nielslyngsoe merged commit be4648e into main Sep 17, 2024
7 of 8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/bugfix/rollback-permissions branch September 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V14: Remove Rollback Permission from user group has no effect
3 participants