Corrections and enhancements to the Healthcheck endpoints #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2313 +/- ##
===========================================
- Coverage 89.78% 89.77% -0.01%
===========================================
Files 324 324
Lines 5569 5567 -2
===========================================
- Hits 5000 4998 -2
Misses 569 569
Continue to review full report at Codecov.
|
mcbhenwood
requested review from
ian-leggett,
paulgain,
peterhudec,
rafenden and
web-bert
web-bert
suggested changes
Dec 10, 2019
| @@ -1,231 +1,298 @@ | |||
| const proxyquire = require('proxyquire') | |||
|
|
|||
| const _successDependencies = [ | |||
There was a problem hiding this comment.
Optional: using _ notation for private is not something I have seen across the rest of the codebase
web-bert
approved these changes
Dec 10, 2019
rafenden
approved these changes
Dec 10, 2019
mcbhenwood
force-pushed
the
chore/separate-pingdom-p1-and-p2-alerts
branch
from
0fcc4ef
to
687d87a
Compare
The purpose of the microservice check is solely to provide a way for CloudFoundry components to be able to tell whether or not the router etc has mounted properly. If CF requires checks of other services it will undertake those directly.
mcbhenwood
force-pushed
the
chore/separate-pingdom-p1-and-p2-alerts
branch
from
687d87a
to
c454784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR addresses a few things:
thisand thebeforeEach()antipattern from unit tests