XmlWebViewInsideScrollView Detector #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .value("true") | ||
| .build() | ||
| context.report(ISSUE, | ||
| context.getElementLocation(parentScrollView), LINT_ERROR_MESSAGE, |
There was a problem hiding this comment.
Nit: Move the LINT_ERROR_MESSAGE to new line for consistency?
There was a problem hiding this comment.
Sure, will do
| TestLintTask.lint() | ||
| .files(xmlSource("res/layout/webview_inside_scrollview_wo_fill_viewport.xml", | ||
| """<?xml version="1.0" encoding="utf-8"?> | ||
| <ScrollView |
There was a problem hiding this comment.
Nit: These are indented weird. and <?xml version> should be on the same indent level
There was a problem hiding this comment.
I see, let me format them
There was a problem hiding this comment.
@ShaishavGandhi i ran a reformat on the file. Still this indent remained
There was a problem hiding this comment.
Done. Manually formatted
ShaishavGandhi
approved these changes
Nov 28, 2019
|
Can you run spotless again? It's failing the build |
Yeah fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lint check to make sure that Scrollview which has WebView as its child sets fillViewport to true
Add
XmlWebViewInsideScrollViewDetectorAdd Unit tests