Add StringFormatNoLocaleDetector #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarr21
approved these changes
Oct 6, 2019
| private fun stringTypes() = setOf("java.lang.String", | ||
| "kotlin.String", | ||
| // Kotlin extension fully qualified name for kotlin.String.format | ||
| "kotlin.text.StringsKt__StringsJVMKt") |
There was a problem hiding this comment.
Can this be resolved via getClass().getName() rather than hard coded?
There was a problem hiding this comment.
I don't think this is possible. The kotlin.String.format is implemented as an inline function. I don't really like this either.
The other option is to branch between Java and Kotlin for this. Check if String.format is implemented as extension and if so, check on the receiver.
There was a problem hiding this comment.
Fixed in 48ee982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
lint-checksmodule for general Java/Kotlin lint rules.