Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIGatewayProxyRequestEvent #409

Merged

Conversation

andre-bisa
Copy link
Contributor

@andre-bisa andre-bisa commented Sep 20, 2023

This PR allows to create Lambda responding to an API Gateway using the Proxy integration. (linked to #48)

@armanbilge
Copy link
Member

Thanks for the PR! We already have the V2 version of this event and an integration with http4s. Is there a significant motivation to support the legacy version as well?

@andre-bisa
Copy link
Contributor Author

Hi @armanbilge,
It's mainly because the HTTP API cannot be set as private. We have a scenario where we use a private REST API with Proxy integration which still uses the old implementation (AFAIK V2 is only supported in the HTTP API).
I think this could be useful to other people as well tho.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining! I guess for completeness we might consider adding an http4s integration for this event too, but that doesn't need to be this PR.

@armanbilge armanbilge changed the title Add APIGatewayProxyRequestEvent Add APIGatewayProxyRequestEvent Sep 21, 2023
@armanbilge armanbilge merged commit d3b32e4 into typelevel:main Sep 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants