Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GH workflow #232

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Update GH workflow #232

merged 2 commits into from
Oct 9, 2023

Conversation

Gauvino
Copy link
Contributor

@Gauvino Gauvino commented Oct 2, 2023 •
edited
Loading

Checklist

  • I have read the Contributing Guidelines
  • I acknowledge that any submitted code will be licensed under the ISC License
  • I confirm that submitted code is my own work
  • I have tested the code, and confirm that it works

Enviroment

  • Operating System: null
  • Node version: 16.14
  • npm version: 8

Description

Upgraded the Github action version

@Gauvino Gauvino changed the base branch from master to dev/0.15.0 October 2, 2023 21:44
@Gauvino Gauvino changed the title Modify worflows and update actions Added Docker Image worflow and update other workflow Oct 2, 2023
tycrek
tycrek requested changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@tycrek tycrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments (also mentioned in the Discord)

.github/workflows/ass-ci.yml Outdated Show resolved Hide resolved
.github/workflows/ass-ci.yml Outdated Show resolved Hide resolved
.github/workflows/ass-ci.yml Outdated Show resolved Hide resolved
@tycrek tycrek added enhancement New feature or request waiting Waiting for more information or changes labels Oct 9, 2023
@Gauvino Gauvino changed the title Added Docker Image worflow and update other workflow Update github workflow Oct 9, 2023
@Gauvino Gauvino changed the base branch from dev/0.15.0 to master October 9, 2023 13:39
@Gauvino Gauvino changed the title Update github workflow Update GH workflow Oct 9, 2023
tycrek
tycrek approved these changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@tycrek tycrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@tycrek tycrek removed the waiting Waiting for more information or changes label Oct 9, 2023
@tycrek tycrek merged commit 5df0458 into tycrek:master Oct 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tycrek tycrek tycrek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gauvino @tycrek