upload to Google Play with GitHub Actions, remove Bitrise #4682
+98
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far! |
Goooler
reviewed
Sep 16, 2024
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - '*' | ||
| pull_request: |
There was a problem hiding this comment.
Suggested change
| pull_request: | |
| push: | |
| branches: | |
| - develop | |
| pull_request: |
There was a problem hiding this comment.
Why? The action already that runs on develop already includes this action, this would run it twice?
There was a problem hiding this comment.
You mean .github/workflows/populate-gradle-build-cache.yml? It has been deleted in this PR.
| - name: Copy CI gradle.properties | ||
| run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties | ||
|
|
||
| - name: Gradle Build Action | ||
| uses: gradle/gradle-build-action@v3 | ||
| uses: gradle/actions/setup-gradle@v4 | ||
| with: | ||
| cache-read-only: ${{ github.ref != 'refs/heads/main' && github.ref != 'refs/heads/develop' }} |
There was a problem hiding this comment.
Suggested change
| cache-read-only: ${{ github.ref != 'refs/heads/main' && github.ref != 'refs/heads/develop' }} |
Comment on lines
+19
to
+27
| - uses: r0adkll/sign-android-release@f30bdd30588842ac76044ecdbd4b6d0e3e813478 | ||
| name: Sign Tusky Blue aab | ||
| id: sign_aab | ||
| with: | ||
| releaseDirectory: app/build/outputs/bundle/blueRelease | ||
| signingKeyBase64: ${{ secrets.KEYSTORE }} | ||
| alias: ${{ secrets.KEY_ALIAS }} | ||
| keyStorePassword: ${{ secrets.KEYSTORE_PASSWORD }} | ||
| keyPassword: ${{ secrets.KEY_PASSWORD }} |
There was a problem hiding this comment.
There was a problem hiding this comment.
I'd prefer it if we don't touch the build.gradle files
There was a problem hiding this comment.
I'll address that in a separated PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4236
I hope I did everything correctly, we will find out after this is merged.
I am setting up the environment variables containing the keys so they are only available to actions that need them.
This should be easier to maintain, GitHub seems to be faster then Bitrise, and we no longer have two checks on every pull request.