Do not cancel the caption dialog on touches on navbar #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tak
approved these changes
Sep 2, 2024
connyduck
reviewed
Sep 2, 2024
app/src/main/java/com/keylesspalace/tusky/components/compose/dialog/CaptionDialog.kt
Outdated
Show resolved
Hide resolved
…ialog/CaptionDialog.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is odd.
I find that if I
The caption dialog disappears and you lose your caption.
(This doesn't happen in ANY other dialog in the app, and in the caption dialog it ONLY happens when the keyboard is up.)
I got a tablet and on the tablet this happens ALL THE TIME.
I was considering adding a "really cancel?" dialog to the caption dialog. But then I discovered (thank you @memorion@mastodon.social) by setting getCanceledOnTouchOutside(false), I could make the bad behavior go ahead completely. In my tests now I can only make the dialog go away by tapping the actual back button.
I believe the potential negative impact of this is low because the caption dialog is full screen, so it was already impossible to trigger the touch outside behavior on purpose.
I might attempt a "really cancel caption?" dialog later because it sucks to lose a long caption you have typed, but I think this fixes my personal problem by itself.