-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different DLC with identical names will replace one another if they are named the same. #16
Comments
sounds good that you solved it yourself so just the question is, are you sure they should have the same ID? looking in the titles.json file and there are no versions of that DLC, only different IDs |
Originally I used the settings to rename it without including the ID number. So, when it came to DLC which had an identical name, it just had one overwrite the other which then showed up as missing when you did the next scan. I would say to just include a setting where if it tries to rename a file to something that already exists it appends something to the end of it to keep them from overwriting. With the one I did above, both of those files resolved to Could just throw a check in so it would resolve to something like Just to keep it from overwriting anything. |
Also, one thing I noticed, with the game |
thank you for more information here, i think i have a grip of the problem now regarding the dot problem, i think i have seen something about this in the original repo as well that this can be a problem, but i will create a separate issue for this, as its not the same problem as the duplicate naming |
Thanks for the responses. much appreciated and thanks for your work. I will let you know if I come across anything else. Edit: Also, separate thing but putting it here because I don't think its the fault of your app but the database it downloads but it identifies the Tactics Ogre Reborn game is one of its DLC. |
@TomTurbine i think i have a working solution for not removing duplicated DLCs by name in the latest PR |
I am kinda busy but will see what I can do, have to leave town tomorrow and won't be back till Wednesday. If I get a chance I will try it on that game I linked before I got to bed and let you know. Edit: Just tried it and they completed to
So, I would call that a win. For some reason it wants to complete the name as a link on here, but needless to say, it worked. |
sounds good! i think i found a case where my solution can be a problem, so i will try to see if i can catch all cases here, so i will keep the issue until i know everything is resolved |
Example
Crash Bandicoot 4 Its About Time [Tubular Skins 1] [010073401175F001]
Crash Bandicoot 4 Its About Time [Tubular Skins 2] [010073401175F001]
Both organize to
Crash Bandicoot 4 Its About Time (DLC)(Crash Bandicoot 4 - Totally Tubular Skins)(0)
So one deletes the other if you try and hit the organize button. Then the next scan shows it as missing the DLC it just deleted.
Need a way to automatically rename DLCs that resolve to the same file name.
Edit: Just changed the organizing method to also include the version number and it resolved it.
The text was updated successfully, but these errors were encountered: