Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing stats when master/main is still building #3

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Fix missing stats when master/main is still building #3

merged 3 commits into from
Oct 14, 2021

Conversation

sbrandwoo
Copy link
Contributor

Context

Currently if the master/main build is still in progress then incorrect stats will be shown. This PR prefers completed builds.

Changes

  • Only look for bundle sizes on completed builds
  • Print the SHA of the build that is compared against

Checklist

@sbrandwoo sbrandwoo added the change:standard Not an emergency or impactful change label Oct 14, 2021
@sbrandwoo sbrandwoo changed the title Success only Fix missing stats when master/main is still building Oct 14, 2021
karanjthakkar
karanjthakkar approved these changes Oct 14, 2021
View reviewed changes
Copy link

@karanjthakkar karanjthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@sbrandwoo sbrandwoo merged commit 9735af2 into master Oct 14, 2021
@sbrandwoo sbrandwoo deleted the success-only branch October 14, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanjthakkar karanjthakkar karanjthakkar approved these changes

Assignees
No one assigned
Labels
change:standard Not an emergency or impactful change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrandwoo @karanjthakkar