Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node, dependencies #16

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Upgrade node, dependencies #16

merged 1 commit into from
Oct 13, 2022

Conversation

sbrandwoo
Copy link
Contributor

Context

Updated to run on node 16.

  • Updated all dependencies
  • Add types for tmp, fixed some typing errors that appeared
  • Some prettier updates (I guess previous PRs didn't use prettier before commiting)

Tested with balance-flows-web: https://github.com/transferwise/balance-flows-web/pull/1489#issuecomment-1277225085

Checklist

@sbrandwoo sbrandwoo added the change:standard Not an emergency or impactful change label Oct 13, 2022
sbrandwoo
sbrandwoo commented Oct 13, 2022
View reviewed changes
src/index.ts
Comment on lines -101 to +74
core.setFailed(e.message);
core.setFailed((e as { message?: any })?.message);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed

@sbrandwoo sbrandwoo merged commit 6512c78 into master Oct 13, 2022
@sbrandwoo sbrandwoo deleted the node16 branch October 13, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikknarusk mikknarusk mikknarusk approved these changes

Assignees
No one assigned
Labels
change:standard Not an emergency or impactful change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrandwoo @mikknarusk