Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top-k accuracy #2097

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

cBournhonesque
Copy link
Contributor

@cBournhonesque cBournhonesque commented Aug 4, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#544

Changes

Add top-k accuracy

Testing

Added unit test

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.24%. Comparing base (f7639bd) to head (695b65c).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/burn-train/src/metric/top_k_acc.rs 96.77% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2097      +/-   ##
==========================================
+ Coverage   86.23%   86.24%   +0.01%     
==========================================
  Files         688      689       +1     
  Lines       88465    88558      +93     
==========================================
+ Hits        76285    76379      +94     
+ Misses      12180    12179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antimora antimora requested a review from laggui August 5, 2024 18:59
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing a new metric!

Implementation LGTM 👍

@antimora antimora merged commit ade664d into tracel-ai:main Aug 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants