Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians : fetch data from API #4

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Math magicians : fetch data from API #4

merged 3 commits into from
Mar 30, 2023

Conversation

torobucci
Copy link
Owner

Display Quote in Calculator app project

  • Use Ninjas Api to fetch quote data
  • Create DisplayQuote.js component
  • Implement DisplayQuote() to fetch data from API
  • Show a loading state
  • Show a error state
  • Import the DisplayQuote.js component into App.js main component
  • use useEffect and useState hooks.

Copy link

@DammyShittu DammyShittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @torobucci,

APPROVED 🟢

Highlights

✔️ API fetch

Great implementation of all the requirements in this milestone. 👏

You have done an amazing job 👍

Your project is complete! There is nothing else to say other than... it's time to merge it. :shipit:

Congratulations! 🎉

CHEERS AND HAPPY CODING!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@torobucci torobucci merged commit 3d0ee37 into dev Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants