Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians :Events #3

Merged
merged 5 commits into from
Mar 30, 2023
Merged

Math magicians :Events #3

merged 5 commits into from
Mar 30, 2023

Conversation

torobucci
Copy link
Owner

@torobucci torobucci commented Mar 29, 2023

Events branch updates

  • Add calculate.js and operate.js in logic directory
  • Installed big.js
  • use useState and props.
  • Implement click event handlers using the math logic from calculate.js and operate.js
  • Ensure calculator app performs calculations correctly.

Copy link

@DuaneDave DuaneDave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @torobucci👋 ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✔️ Correct usage gitflow
✔️ Linters are passing
✔️ Event are passed down correctly via props

Optional suggestions

N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@torobucci torobucci merged commit d871392 into dev Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants