Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: store instantiation #461

Merged
merged 1 commit into from
Mar 5, 2024
Merged

refactor: store instantiation #461

merged 1 commit into from
Mar 5, 2024

Conversation

Freyskeyd
Copy link
Member

Description

ValidatorStore is able to create the whole set of others stores. This PR is refactoring a bit how we access the open method to create the store.
Calling new with a single path will create the whole set of stores.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd force-pushed the refactor/process-and-errors branch 4 times, most recently from d82e2a0 to 2bf25cd Compare February 20, 2024 15:18
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@cc0c7b5). Click here to learn what that means.

Files Patch % Lines
crates/topos-test-sdk/src/storage/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage        ?   70.79%           
=======================================
  Files           ?      226           
  Lines           ?    12421           
  Branches        ?        0           
=======================================
  Hits            ?     8793           
  Misses          ?     3628           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the refactor/process-and-errors branch 2 times, most recently from 4e12073 to af865ae Compare February 21, 2024 09:44
@Freyskeyd Freyskeyd force-pushed the refactor/store-instantiation branch 2 times, most recently from 4b7e000 to 6166fda Compare February 21, 2024 14:53
@Freyskeyd Freyskeyd force-pushed the refactor/process-and-errors branch 2 times, most recently from 4e678be to 719c5fc Compare March 1, 2024 20:28
@Freyskeyd Freyskeyd force-pushed the refactor/store-instantiation branch from 6166fda to 9f81725 Compare March 1, 2024 20:57
@Freyskeyd Freyskeyd marked this pull request as ready for review March 1, 2024 21:02
@Freyskeyd Freyskeyd requested a review from a team as a code owner March 1, 2024 21:02
@Freyskeyd Freyskeyd requested review from gruberb and hadjiszs and removed request for a team March 1, 2024 21:02
Base automatically changed from refactor/process-and-errors to main March 5, 2024 09:53
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd force-pushed the refactor/store-instantiation branch from 9f81725 to 9e27632 Compare March 5, 2024 09:54
@dvdplm dvdplm merged commit 213b8d4 into main Mar 5, 2024
21 checks passed
@dvdplm dvdplm deleted the refactor/store-instantiation branch March 5, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants