-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: store instantiation #461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
force-pushed
the
refactor/store-instantiation
branch
from
February 20, 2024 09:23
3c510ee
to
2d146d2
Compare
Freyskeyd
force-pushed
the
refactor/process-and-errors
branch
4 times, most recently
from
February 20, 2024 15:18
d82e2a0
to
2bf25cd
Compare
Freyskeyd
force-pushed
the
refactor/store-instantiation
branch
from
February 20, 2024 15:19
2d146d2
to
5873009
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage ? 70.79%
=======================================
Files ? 226
Lines ? 12421
Branches ? 0
=======================================
Hits ? 8793
Misses ? 3628
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Freyskeyd
force-pushed
the
refactor/process-and-errors
branch
2 times, most recently
from
February 21, 2024 09:44
4e12073
to
af865ae
Compare
Freyskeyd
force-pushed
the
refactor/store-instantiation
branch
2 times, most recently
from
February 21, 2024 14:53
4b7e000
to
6166fda
Compare
Freyskeyd
force-pushed
the
refactor/process-and-errors
branch
2 times, most recently
from
March 1, 2024 20:28
4e678be
to
719c5fc
Compare
Freyskeyd
force-pushed
the
refactor/store-instantiation
branch
from
March 1, 2024 20:57
6166fda
to
9f81725
Compare
Freyskeyd
requested review from
gruberb and
hadjiszs
and removed request for
a team
March 1, 2024 21:02
hadjiszs
approved these changes
Mar 4, 2024
dvdplm
reviewed
Mar 5, 2024
dvdplm
approved these changes
Mar 5, 2024
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Freyskeyd
force-pushed
the
refactor/store-instantiation
branch
from
March 5, 2024 09:54
9f81725
to
9e27632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ValidatorStore
is able to create the whole set of others stores. This PR is refactoring a bit how we access theopen
method to create the store.Calling
new
with a singlepath
will create the whole set of stores.PR Checklist: