socketaddr: implement conversions for tokio and std unix SocketAddr
#6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement `From` to convert `tokio::unix::SocketAddr` to and from Rust's `std::os::unix::net::SocketAddr`. These types were (I'm told) originally separate because `mio` had a distinct `SocketAddr` type. This patch makes it possible to convert between them more easily. Fixes: tokio-rs#6864
|
Note: As a forward-compatibility measure, if we think that someday |
Darksonn
approved these changes
Sep 25, 2024
Done! My documentation isn't always the greatest, so please feel do free to make any suggestions about how to clarify it. |
Darksonn
reviewed
Sep 25, 2024
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Fromto converttokio::unix::SocketAddrto and from Rust'sstd::os::unix::net::SocketAddr.These types were (I'm told) originally separate because
miohad a distinctSocketAddrtype. This patch makes it possible to convert between them more easily.Fixes: #6864